marcothms/8086-rs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix(interpreter): set flags correctly for inc/dec/neg

Browse Source
This commit is contained in:
Marco Thomas
2025-07-02 17:15:40 +09:00
parent 4f161f47f6
commit cf3383c23a
1 changed files with 39 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

55
src/interpreter/interpreter.rs
View File

@@ -358,25 +358,39 @@ impl Interpreter {
/*
* INC
*/
Mnemonic::INC_Reg(reg) => self
.computer
.regs
.write(reg, self.computer.regs.read(reg) + 1),
Mnemonic::INC_Mod(target) => {
let val = self.computer.read_modrm(target)?;
self.computer.write_modrm(target, val + 1)?
Mnemonic::INC_Reg(reg) => {
let cf = self.computer.flags.cf;
let dest = ModRmTarget::Register(reg);
let src = ArithmeticOperand::Immediate(ImmediateOperand::Byte(1));
self.computer.add(dest, src)?;
// The CF flag is not affected
self.computer.flags.cf = cf;
}
Mnemonic::INC_Mod(dest) => {
let cf = self.computer.flags.cf;
let src = ArithmeticOperand::Immediate(ImmediateOperand::Byte(1));
self.computer.add(dest, src)?;
// The CF flag is not affected
self.computer.flags.cf = cf;
}
/*
* DEC
*/
Mnemonic::DEC_Reg(reg) => self
.computer
.regs
.write(reg, self.computer.regs.read(reg) - 1),
Mnemonic::DEC_Mod(target) => {
let val = self.computer.read_modrm(target)?;
self.computer.write_modrm(target, val - 1)?
Mnemonic::DEC_Reg(reg) => {
let cf = self.computer.flags.cf;
let dest = ModRmTarget::Register(reg);
let src = ArithmeticOperand::Immediate(ImmediateOperand::Byte(1));
self.computer.sub(dest, src)?;
// The CF flag is not affected
self.computer.flags.cf = cf;
}
Mnemonic::DEC_Mod(dest) => {
let cf = self.computer.flags.cf;
let src = ArithmeticOperand::Immediate(ImmediateOperand::Byte(1));
self.computer.sub(dest, src)?;
// The CF flag is not affected
self.computer.flags.cf = cf;
}
/*
@@ -624,8 +638,17 @@ impl Interpreter {
.write_modrm(target, !self.computer.read_modrm(target)?)?;
}
Mnemonic::NEG(target) => {
let val = !self.computer.read_modrm(target)?;
self.computer.write_modrm(target, val + 0b1)?;
let lhs = !self.computer.read_modrm(target)?;
let rhs = ImmediateOperand::Byte(1);
let result = lhs + rhs;
self.computer.flags.cf = result < self.computer.read_modrm(target)?;
self.computer.flags.of =
(lhs.msb() && rhs.msb()) && (result.msb() != lhs.msb());
self.computer.flags.zf = result.zero();
self.computer.flags.sf = result.msb();
self.computer.flags.pf = result.parity();
self.computer.write_modrm(target, result)?;
}
/*